Skip to content

added telemetry to the errorHandler when jupyter is or isn't installed #8305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DavidKutu merged 1 commit into from
Oct 30, 2019
Merged

added telemetry to the errorHandler when jupyter is or isn't installed #8305

DavidKutu merged 1 commit into from
Oct 30, 2019

Conversation

@DavidKutu
Copy link

@DavidKutu DavidKutu commented Oct 30, 2019

For #6983

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@DavidKutu DavidKutu added the no-changelog No news entry required label Oct 30, 2019
@DavidKutu DavidKutu self-assigned this Oct 30, 2019
@codecov-io
Copy link

codecov-io commented Oct 30, 2019 •
edited
Loading

Codecov Report

Merging #8305 into master will increase coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8305      +/-   ##
==========================================
+ Coverage   59.32%   59.33%   +<.01%     
==========================================
  Files         504      504              
  Lines       23087    23096       +9     
  Branches     3736     3737       +1     
==========================================
+ Hits        13697    13704       +7     
- Misses       8498     8500       +2     
  Partials      892      892
Impacted Files Coverage Δ
src/client/telemetry/index.ts 86.13% <ø> (ø) ⬆️
src/client/datascience/constants.ts 100% <100%> (ø) ⬆️
...rc/client/datascience/errorHandler/errorHandler.ts 67.5% <66.66%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d17206c...625c62e. Read the comment docs.

@DavidKutu DavidKutu merged commit 7418b74 into master Oct 30, 2019
@DavidKutu DavidKutu deleted the davidkutu/telemetry_when_jupyter_installed branch October 30, 2019 23:57
@lock lock bot locked as resolved and limited conversation to collaborators Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rchiodo rchiodo rchiodo approved these changes

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

@IanMatthewHuff IanMatthewHuff Awaiting requested review from IanMatthewHuff

Assignees

@DavidKutu DavidKutu

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DavidKutu @codecov-io @rchiodo